Revert use_gram_newton_schulz default to False due to bug#55
Merged
JohnLangford merged 1 commit intomicrosoft:mainfrom Apr 8, 2026
Merged
Revert use_gram_newton_schulz default to False due to bug#55JohnLangford merged 1 commit intomicrosoft:mainfrom
JohnLangford merged 1 commit intomicrosoft:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts the default value of
use_gram_newton_schulzback toFalsein all optimizers (Dion2,Muon,NorMuon, andDistributedOrthoBase) due to a bug in the gram Newton-Schulz implementation.This was set to
Truein #54 but causes issues, so this PR rolls it back until the bug is fixed.